search

vmiklos / plees-tracker

Plees Tracker is a simple sleep tracker for your Android phone.
https://vmiklos.hu/plees-tracker/
MIT License
151 stars 38 forks source link

build: Add debug suffix variant #409

Closed Lastaapps closed 9 months ago

Lastaapps commented 9 months ago

The first change removes the line, as it is ignored anyway and has no meaning anymore.

The second change changes the suffix of the debug variant – you can have both the debug and release variants installed at the same time – you can track your own sleep in the production variant and do experiment in the debug one. I can also change app label/icon color in the debug variant if you want, so it can be distinguished more easily. If you don't want this change, I understand, but it's generally really useful.

vmiklos commented 9 months ago

com.android.ide.common.signing.KeytoolException: Failed to read key from store "/Users/runner/work/plees-tracker/plees-tracker/app/keystore/plees_keystore.jks": Tag number over 30 is not supported

Seems to be the root cause of the CI failure. Perhaps try to remove the first hunk to see if it indeed does nothing?

Lastaapps commented 9 months ago

Ok, I reverted the first change. But if it helps, there is something really suspicious about the signing/building process.

vmiklos commented 9 months ago

Still fails, weird. I'll try to investigate.

vmiklos commented 9 months ago

Err, I think I know what's going on here. People asked for automated signed builds for releases, I've added that. But when CI runs your patch, then it runs as your user, so won't see the signing key, and then CI fails. Let me re-create a PR that just has your patch and let's see if things pass there, I bet they will.

vmiklos commented 9 months ago

See #411, your original commit was fine after all. Thanks for the contribution!

Lastaapps commented 9 months ago

Oh, interesting, nice and thanks.