search

vmiklos / plees-tracker

Plees Tracker is a simple sleep tracker for your Android phone.
https://vmiklos.hu/plees-tracker/
MIT License
149 stars 38 forks source link

DND Code Review changes #449

Closed MachineThing closed 2 months ago

MachineThing commented 2 months ago

I implemented all (if not most of) the suggestions you made in the code review at pull request #448

By the way sorry about the fact there are no tests, I'm mostly a beginner with Android development and don't have much experience with testing in general as well. But hopefully these changes find you well!

vmiklos commented 2 months ago

Could you rebase this on top of master? Looks like this PR contains both your old & new work, while it should only contain your new work. :-) Thanks.

vmiklos commented 2 months ago

Ah, I just realized it's a single commit, I just did it for you.

vmiklos commented 2 months ago

By the way sorry about the fact there are no tests, I'm mostly a beginner with Android development and don't have much experience with testing in general as well.

I like to believe I'm quite good at testing (I have python/rust/go projects where test coverage is almost complete) and Android testing is quite hard. :-) So no problem, I just tried my luck.

MachineThing commented 2 months ago

Ah, I just realized it's a single commit, I just did it for you.

Yeah sorry about that, I thought it would of done that automatically.

Care to rework to not warn in the default config? After that iteration this should be fine, I think. Thanks!

If I'm correct you mean to remove the log.w methods and so I removed them in commit a1562e0

vmiklos commented 2 months ago

The warnings are gone in the default config, thanks.