vmiklos / plees-tracker

Plees Tracker is a simple sleep tracker for your Android phone.
https://vmiklos.hu/plees-tracker/
MIT License
149 stars 38 forks source link

allow setting star ratings from overview #454

Open foss- opened 2 months ago

foss- commented 2 months ago

Reproducer steps

  1. when on overview page and looking to set a star rating for a certain night in the past sleeps listing, when tapping the stars...

Actual result ... a separate page opens.

Expected behavior ... opening a separate page really isn't needed and complicates the interaction unnecessarily. It would be easier if setting the star rating was possible from the Past sleeps overview page.

vmiklos commented 2 months ago

Yes, this is indeed a problem. The trouble is that it seems the intention is that no interactive items are included in an item of a recycler view, which goes against the idea of interacting with the rating there.

See #161, do you have an idea how to do what you want in a way that doesn't re-introduce that issue?

foss- commented 2 months ago

Sorry I have no understanding of how recycler view works. If this is a limitation, setting stars on that view probably won't be feasible.

From a UX standpoint, preventing a reintroduction of #161 seems feasible via two mechanisms:

Wondering how other Android apps handle star ratings. I had a glance at my installed apps but none used star ratings. Probalby the commercial sleep trackers do. But then again those are not open source so can't be inspected easily as to how their implementation works.