search

vmiklos / plees-tracker

Plees Tracker is a simple sleep tracker for your Android phone.
https://vmiklos.hu/plees-tracker/
MIT License
147 stars 38 forks source link

Support Material 3+You. #464

Open RokeJulianLockhart opened 2 weeks ago

RokeJulianLockhart commented 2 weeks ago

  1. Reproducer steps

    1. Install https://gitlab.com/CalyxOS/calyxos.org/-/blob/bdc88ebb6cbeddd0ca1c583ba7685605523dda63/pages/install/devices/blueline/linux.md#install-calyxos Android 14.
    2. Install https://github.com/vmiklos/plees-tracker/releases/download/v24.2.2/app-release.apk.

  2. Actual result

    Each Material 2 GUI component is styled manually and independently from the system. Most prominently, the title bar.

  3. Expected behavior

    I expected it to adhere to https://m3.material.io/styles/color/dynamic/user-generated-source.

  4. Additional information

    Additional rationale is available at https://github.com/QuickLyric/QuickLyric/issues/271#issue-1054902836.

vmiklos commented 2 weeks ago

Are you interested in looking at this yourself?

Also, are you aware of some other open-source Android app that has a title bar color depending on the wallpaper of the user? It would be good to see what APIs or configs they use to have this. Also to see if they do this by default or if this is opt-in. Keeping the default unchanged always makes me feel safer.

My first thought is that I'm not particularly interested in this (dark mode in itself is already a bit painful), but if somebody does the work, I don't mind. :-) Thanks.

RokeJulianLockhart commented 2 weeks ago

https://github.com/vmiklos/plees-tracker/issues/464#issuecomment-2067656681

@vmiklos, defaults indeed are usually best. I'm not an Android developer, so I assumed that M3 would be the new default for any major Android GUI framework. However, I recall that something similar was stated at https://github.com/Divested-Mobile/Hypatia/issues/57#issuecomment-1879734898. Regardless, https://github.com/AChep/keyguard-app/blob/c1fce0227ede567a62601dc44b94f9a9f8639c51/README.md#looks is a good example of what I'm referring to. As depicted, headings for M3 significantly differ to M2. Specifically, if I use a window manager as an analogy, they are more like CSD than SSD, yet remain visually consistent overall.