search

vmitsaras / js-offcanvas

A lightweight, flexible jQuery off-canvas navigation plugin which lets you create fully accessible sidebar or top/bottom sliding (or push) panels with keyboard interactions and ARIA attributes.
http://codepen.io/vmitsaras/pen/gwGwJE
MIT License
270 stars 30 forks source link

Is it working with twitter bootstrap 3.3.7 and 4? #18

Closed YusufAkyol closed 6 years ago

YusufAkyol commented 6 years ago

Thanks for your sharing... It's very usefull. But I wonder, is it working with Bootstrap? Thanks. Best regards.

vmitsaras commented 6 years ago

It's in the README

Bootstrap v4 - Codepens

YusufAkyol commented 6 years ago

Many thanks, Vasileios Mitsaras... Best regards...

vmitsaras commented 6 years ago

Also a good one: https://bootstrapcreative.com/pattern/bootstrap-4-off-canvas-side-menu-navbar/ https://codepen.io/JacobLett/full/VWrpvv

kevinmamaqi commented 6 years ago

@vmitsaras it doesn't work with bootstrap modals if they are placed inside the c-offcanvas-content-wrap class.

It is due to the following code:

.c-offcanvas, .c-offcanvas-content-wrap {
    -webkit-transform: translate3d(0, 0, 0);
    transform: translate3d(0, 0, 0);
    -webkit-backface-visibility: hidden;
    backface-visibility: hidden;
}

And the z-index.

vmitsaras commented 6 years ago

@kevinmamaqi what doesn't work. the offcanvas-panel or the modals? Which Version? Codepen Demo?

kevinmamaqi commented 6 years ago

Hello again @vmitsaras what doesn't work are the bootstrap modals, let me show you a video: https://streamable.com/9g1i5 - I am using the last version of both

YusufAkyol commented 6 years ago

Hi Kevin,

Sorry, this issue is very long time ago. That's, if you say it works than it works. Thanks for reply, I'm very glad to know you, best regards.

On Fri, Aug 31, 2018, 16:15 Kevin notifications@github.com wrote:

Hello again @vmitsaras https://github.com/vmitsaras what doesn't work are the bootstrap modals, let me show you a video: https://streamable.com/9g1i5 - I am using the last version of both

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/vmitsaras/js-offcanvas/issues/18#issuecomment-417660336, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_cpMrrFsUxa8KkO_qeQLIm0b6-_LGaks5uWTbwgaJpZM4SUbc1 .

--

Her şey gönlünüzce olsun... Selam ve sevgilerimle...

Yusuf Nuh Akyol https://www.linkedin.com/in/yusuf-nuh-akyol-54701385