First project not working

lcsqlpete commented 4 years ago

Just downloaded and set everything up using the Codepen example. I see the Left button and the para text I put in the aside display immediately on page load and clicking the button does nothing. No console error and the css and js files are where they're supposed to be.

Help please, html is below. This on OSX Catalina running Chrome.

`

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Offcanvas</title>
    <link rel="stylesheet" href="https://cdn.kleenedge.com/dev/css/js-offcanvas.css">
</head>

<body>

    <main class="c-offcanvas-content-wrap" role="main">
        <button class="c-button js-offcanvas-trigger" data-offcanvas-trigger="off-canvas-left">Left</button>
    </main>

    <!--Offcanvas Panels-->
    <aside class="js-offcanvas" id="off-canvas-left" role="complementary"><p>Here it is!</p></aside>

    <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.12.4/jquery.min.js"></script>
    <script src="https://cdn.kleenedge.com/dev/js/js-offcanvas.pkgd.js"</script>
    <script>
        $(function () {
            $(document).trigger("enhance");
        });
    </script>

</body>

`

vmitsaras commented 4 years ago

Hi @lcsqlpete

you missed a closing tag (>)

 <script src="https://cdn.kleenedge.com/dev/js/js-offcanvas.pkgd.js"</script>

 <script src="https://cdn.kleenedge.com/dev/js/js-offcanvas.pkgd.js"></script>

lcsqlpete commented 4 years ago

Duh! Sorry to bother you, that fixed it.

Sent with Shift https://tryshift.com/?utm_source=SentWithShift&utm_campaign=Sent%20with%20Shift%20Signature&utm_medium=Email%20Signature&utm_content=General%20Email%20Group

On Tue, Jan 7, 2020 at 3:43 AM Vasileios Mitsaras notifications@github.com wrote:

Hi @lcsqlpete https://github.com/lcsqlpete

you missed a closing tag (>)

<script src="https://cdn.kleenedge.com/dev/js/js-offcanvas.pkgd.js"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vmitsaras/js-offcanvas/issues/50?email_source=notifications&email_token=ACA2CFGETW2W3JBUG4PIIJ3Q4RTGPA5CNFSM4KDOPUSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIITNRY#issuecomment-571553479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACA2CFE664OAUZKTVGGMQS3Q4RTGPANCNFSM4KDOPUSA .

vmitsaras / js-offcanvas

First project not working #50