vmngr / libvirt-old

Libvirt bindings for Node.js®
https://vmngr.com/
MIT License
11 stars 7 forks source link

Adding features from virsh with live affect #6

Open libvirtadept opened 4 years ago

libvirtadept commented 4 years ago

Hi, Leon Do you consider to add virsh-like features like live editing of Virtual Machine interface bandwith limit for example.

I think it is actually possible. But needed to include additional header files from libvirt/src/util

Implemented:

libvirtadept commented 4 years ago

Moved domain memory stats, node memory stats, node cpu stats @leonrinkel, can you review it ? (in forked repo)

libvirtadept commented 4 years ago

Moved domain memory stats, node memory stats, node cpu stats @leonrinkel, can you review it ? (in forked repo)

leonrinkel commented 4 years ago

I couldn't find it in your repo, can you do a PR?

libvirtadept commented 4 years ago

Oops, missed that. All time pushed to dev/xml branch :D https://github.com/libvirtadept/libvirt/commit/8fc855e2fefae4467a0873689c5c83e1d3cb3e54

But cpu usage requiring some time for calculation based on cpu time. After holidays i'm didn't looked into repo due to chilling.

I think i will continue to test things after few days. Created PR. There is actually a lot of possible redundant code.