search

vmonaco / frailtySurv

General Semiparametric Shared Frailty Model
12 stars 2 forks source link

In two files define STRICT_R_HEADERS and use M_PI #8

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Dear Vinnie,

Your CRAN package frailtySurv uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here, we prefixed each #include with STRICT_R_HEADERS. The actual change that is needed is the change from PI to M_PI in one file.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

vmonaco commented 3 years ago

Awesome, thanks Dirk! I'll get this onto CRAN in the next week or so.

eddelbuettel commented 3 years ago

Wicked -- but no rush. As you can see from the list, I am only about half-way through, of the ones filed only a portion have merged (but yet two are on CRAN). So if you want to / need to take more time by all means do.