vmprof / vmprof-python

vmprof - a statistical program profiler
http://vmprof.com
Other
433 stars 54 forks source link

Add wheel for Python3.7+ #252

Closed KimiNewt closed 8 months ago

KimiNewt commented 1 year ago

Wheels are missing for newer Python versions.

I wanted to use one in Python 3.7 that include libunwind (in a place where I can't apt-get).

I couldn't see anything about how libunwind was packaged previously in setup.py or elsewhere, and I see it's simply placed in .libs_vmprof in previous version. If you could tell me how you packaged it I could maybe automate the process.

ilanKeshet commented 10 months ago

any updates on publishing new wheels?

mattip commented 10 months ago

We need to solve the windows segfault in tests to merge #257.

ilanKeshet commented 8 months ago

Hi @mattip, i see that #257 was merged 🥳

Any room for optimism with regards to compiled wheels for python 3.9+?

mattip commented 8 months ago

I see the latest merge to master created wheels as artifacts here. Could you try downloading the artifact, unzipping it, and checking if those wheels work? If so I can upload them to PyPI

ilanKeshet commented 8 months ago

Sure,

I've checked vmprof-0.4.15-cp39-cp39-macosx_10_9_x86_64.whl and vmprof-0.4.15-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl and can report they are both working as expected.

Specifically for the linux version, it works without requiring that i'd install libunwind-dev in the docker image 🥳

@mattip Thank you so much for taking the time and looking into this issue 🙏 😄

mattip commented 8 months ago

Great. I added a tag 0.4.16 and will upload the artifacts once the wheels build.

ilanKeshet commented 8 months ago

Hi @mattip, noticed pypi hasn't yet been updated, anything i can do to help?

mattip commented 8 months ago

It turns out I cannot upload to PyPI. I have asked the current maintainers to upload the wheels.

ilanKeshet commented 8 months ago

Thank you 🙏

mattip commented 8 months ago

The 0.4.17 wheels are up. Closing.