vmsreeram / moodle-qtype_essayannotate

A moodle question plugin that supports PDF annotation
0 stars 0 forks source link

invalid lang strings #27

Closed danmarsden closed 3 months ago

danmarsden commented 3 months ago

the lang file is for translation - not config values:

these all seem like configuration and should not be in the lang file at all.

$string['annotator_url'] = '/question/type/essayannotate/annotator/annotator.php';
$string['gs_cmd'] = ' -sDEVICE=pdfwrite -dCompatibilityLevel=1.4 -dNOPAUSE -dBATCH -sOutputFile="';
$string['rgb_black'] = 'rgb(0, 0, 0)';
$string['rgb_blue'] = 'rgb(2, 2, 182)';
$string['rgb_green'] = 'rgb(13, 93, 13)';
$string['rgb_red'] = 'rgb(251, 17, 17)';
$string['rgb_yellow'] = 'rgb(255, 255, 0)';
$string['rgba_black'] = 'rgba(0, 0, 0, 0.3)';
$string['rgba_blue'] = 'rgba(2, 2, 182, 0.3)';
$string['rgba_green'] = 'rgba(13, 93, 13, 0.3)';
$string['rgba_red'] = 'rgba(251, 17, 17, 0.3)';
$string['rgba_yellow'] = 'rgba(255, 255, 0, 0.3)';

Also - string concatenation in the lang packs is not allowed - it causes problems for the Moodle translation tool

eg: $string['test'] = "sometext"."somemoretext"; or $string['test'] = "sometext".$string['someotheritem'];

each string must be contained within one set of quotes eg: $string['test'] = "sometext somemoretext";