Support of key exchange diffie-hellman-group1-sha1

[Nuramon27]

Since VSCode version 1.82, ssh key exchange with a server via the algorithm "diffie-hellman-group1-sha1" does not work anymore. Prior to version 1.5.58 of this extension, synchronization used to fail with the error message "client error: Error: Handshake failed: Unknown DH group".

Since the update to version 1.5.58, the error message "client error: Error: Handshake failed: no matching key exchange algorithm" appears instead. This change probably stems from commit 7f2b52b which changed something in the treatment of key exchange methods.

Steps to reproduce:

• On the VMS server, setup "diffie-hellman-group1-sha1" as the ssh key exchange method (if this is not the default anyway)
• setup ssh-helper-settings and synchronizer-settings for synchronization with some folder on the server
• From VSCode, try to synchronize with the "Synchronize project files" command
• Enter password (and username, if necessary)

Synchronization will then fail with the error message "client error: Error: Handshake failed: no matching key exchange algorithm".

Versions:

Windows 10 Pro 10.0.19045 Build 19045 VSCode: 1.82.2 VMS IDE: 1.5.58

This issue still appears with VMS IDE as the only installed extension.

[vorfol]

Since the version 1.5.58, no default algorithms and kex are added to the connection by default. You should define your own settings in "algorithms" sections of the connection. https://wiki.vmssoftware.com/SSH_Settings

[Nuramon27]

Thanks for the quick reply. Unfortunately, this still does not work. When I define diffie-hellman-group1-sha1 in the "kex"-setting in the "alrgorithms" section, the only change is that the error message reads "client error: Error: Handshake failed: Unknown DH group" again, but synchronization still does not happen.

[vorfol]

The support of 'diffie-hellman-group1-sha1' and 'diffie-hellman-group1-sha1' is removed from VS Code version 1.82.