vmware-archive / blackbox

record metrics and logs
Apache License 2.0
10 stars 5 forks source link

Syslog messages are truncated at 9990 bytes (including header) #7

Closed bandesz closed 6 years ago

bandesz commented 6 years ago

Hi,

There might be a typo in the code here:

https://github.com/concourse/blackbox/blob/7fe552206539f36acdefee87e128394abb80ec2d/syslog/drainer.go#L40

The maximum TCP message size is set to 9990 while in the used library the default is 99990:

https://github.com/papertrail/remote_syslog2/blob/5bae4a1ac1c22d2d80b24550dda5b721bf9ed0c8/config.go#L82

I don't know if this is intentional or a mistake, either way it should be documented or fixed.

bandesz commented 6 years ago

Pull request: https://github.com/concourse/blackbox/pull/8

vito commented 6 years ago

merged the PR, thanks!