search

vmware-archive / cascade

A Just-In-Time Compiler for Verilog from VMware Research
Other
433 stars 44 forks source link

Propagate command failures in shell scripts by chaining them with &&. #237

Closed yurivict closed 4 years ago

yurivict commented 4 years ago

Overview

Description:

When some command in the middle of the shell script fails shell by default keeps running subsequent commands, which isn't what is desired when you run a compiler chain. This patch chains the commands with &&. This way when one command would fail - the whole script would fail, which is a desired behavior.

Related issue(s) (if applicable): Fixes #

Checklist (Definition of Done):

vmwclabot commented 4 years ago

@yurivict, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.