vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.42k stars 761 forks source link

New Radio button control does not have disabled design #2665

Closed speti43 closed 6 years ago

speti43 commented 6 years ago

Describe the bug

New Radio button control does not have disabled design

How to reproduce

https://stackblitz.com/edit/clr-radio-missing-disabled-design

Steps to reproduce the behavior:

  1. Go to Stackblitz
  2. The radiobutton itself is disabled, if I add the disabled attribute, but the css and the UI does not reflect the state, as you see I've tried every possibility, the documentation does not describe, how to do it: https://vmware.github.io/clarity/documentation/v0.13/radio

The old version can be seen at the bottom, we need some way to pass the control container that this is disabled, and apply a css class.

Expected behavior

Let the user see, this control is disabled

Versions

App

Angular CLI: 6.1.3 Node: 8.11.2 Clarity: 0.13 Device:

Type: Dell latitude E5550 OS: Windows 10 64bit Browser: Chrome - Version: 69.0.3497.92 (Official Build) (64-bit)

speti43 commented 6 years ago

Hi @mathisscott @gnomeontherun,

Could you help me, how to apply the new disabled state of radio button? I updated the packages, because as I see my issue is fixed and closed, but I still can't see this in documentation, and I tried in my demo code, the radio button is disabled now, but the design does not reflect that as in the old version. https://stackblitz.com/edit/clr-radio-missing-disabled-design

Thanks, Peter

gnomeontherun commented 6 years ago

It is merged into master, but not yet part of a release. We'll be doing a 1.0 beta soon that will contain this fix.

speti43 commented 6 years ago

Sounds good, thank you for the update.

github-actions[bot] commented 4 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.