search

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.42k stars 761 forks source link

Already clicked "Select All" button remains enabled #2734

Closed zlevai closed 6 years ago

zlevai commented 6 years ago

Describe the bug

"ALLE AUSWÄHLEN!!" button remains enabled once that was clicked. So button does not reflect that all the check-boxes are checked in. Note: If I check in all items manually checkbox by checkbox then ALLE AUSWÄHLEN! button becomes to disabled (works by expected).

How to reproduce

Steps to reproduce the behavior:

  1. Go to https://vmware.github.io/clarity/documentation/v0.13/datagrid/hide-show
  2. Click on column option button/toggle below the grid -> Column option panel opens
    • Click on ALLE AUSWÄHLEN! button -> All check-boxes becomes to checked in Actual result: "Select All!" is enabled

Expected behavior

Expected result: "Select All!" is disabled

Versions

Angular CLI: 6.1.9 Node: 8.11.2 Clarity: 0.13.4

Device: Type: Dell latitude E5550 OS: Windows 10 64bit Browser: Google Chrome, Version 69.0.3497.100 (Official Build) (64-bit)

Additional notes

If I check in all items manually checkbox by checkbox then ALLE AUSWÄHLEN! button becomes to disabled (works by expected).

AbhiAgarwal192 commented 6 years ago

@zlevai Do you mean after you click on "Select ALL" button, the name for the button should change to something like "Unselect All"?

zlevai commented 6 years ago

@AbhiAgarwal192 Not. I would expect to work the same way when you check in all the checkbox manually one by one. Then "Select ALL" button changes to disabled, so that is greyed and not clickable.

AbhiAgarwal192 commented 6 years ago

@zlevai Fixed this issue. Raised a Pull Request for the fix.

zlevai commented 6 years ago

@AbhiAgarwal192 Thanks a lot.

cbhumireddy commented 6 years ago

@zlevai @AbhiAgarwal192 : I have already raised PR first day itself. Waiting for one more approval to merge. See PR for more details.

github-actions[bot] commented 4 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.