fix(core): lint/logging - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

fix(core): lint/logging #6488

Closed coryrylan closed 2 years ago

coryrylan commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the new behavior?

This fixes the last linting/warning errors in the Core codebase for both the build and tests. There should be no warnings/logs in the console now.

remove last of the deprecated jasmine done use/warnings
update private property to use @state to remove private api warning
fix statement warning caught by TS/ESBuild compiler (boolean check guaranteed will always be true)
fix the unused public export warning from rollup

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information