search

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

Datagrid rows changing information is not read by screen reader after filtered #6499

Closed KingMario closed 2 years ago

KingMario commented 2 years ago

Describe the bug

When the rows are filtered out, the rows changing information including total item count and/or rows on the current page is not read by screen reader

How to reproduce

Steps to reproduce the behavior:

  1. Go to 'stackblitz clarity datagrid simple sample'
  2. Run a screen reader such as VoiceOver for MacOS or NVDA for Windows
  3. Click on the filter icon of datagrid 'name' column header and enter ce to filter out the rows
  4. The rows changed from 7 to 4 (including the header and footer), but nothing read by the screen reader

Expected behavior

The rows changing information should be read by the screen reader. The information should include not only how many rows are shown in the current page, but also totally how many items are filtered out.

Versions

Clarity project:

Clarity version:

Framework:

Framework version:

Angular 11

gnomeontherun commented 2 years ago

Hi KingMario, is this from a VMware product or something else? This is probably duplicated in our list @scroniser may know.

KingMario commented 2 years ago

Hi Jeremy, it's from a portal of VMware, and is originally raised by India VPAT test team.

In the portal, I have created a directive to announce the info of sorting and filtering.

But I think it's better to have the information announced by the Datagrid component.

scroniser commented 2 years ago

Hi @KingMario! I’m on the internal accessibility team at VMware, specifically focused on assisting the Clarity team. Although I’m in the US, both locales fall under the same group.

Given this request was generated from an internal audit, could you DM me on Slack so I can better assist?

gnomeontherun commented 2 years ago

Thanks @KingMario let's track and tackle these through our internal process so we don't have duplication of efforts here. I'm going to close this as a duplicate. Thanks!

Also, Clarity intentionally does not make announcements due to the complexity of trying to handle that automatically for each use case. We expect applications to handle this as necessary.

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.