vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

fix(angular): fix accordion panel initialization and infinite loop bugs #6528

Closed steve-haar closed 2 years ago

steve-haar commented 2 years ago

Signed-off-by: Steve Haar info@stevehaar.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When programmatically closing an already closed accordion panel (clrAccordionPanelOpen) without using clrAccordionMultiPanel, any open panels will close. This can cause some weird behaviors including improper initialization and can result in infinite loops when binding to clrAccordionPanelOpen.

Issue Number: https://github.com/vmware/clarity/issues/5822

What is the new behavior?

When programmatically closing an already closed accordion panel, nothing should happen. This should fix all issues listed in https://github.com/vmware/clarity/issues/5822.

Does this PR introduce a breaking change?

Other information

netlify[bot] commented 2 years ago

✔️ Deploy Preview for zzz-angular-clarity-design-old ready!

🔨 Explore the source changes: 60ff0254614b41d7ce1f7c90001d6d2acdbd2ca6

🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61c10a2ce1aac40008e99064

😎 Browse the preview: https://deploy-preview-6528--zzz-angular-clarity-design-old.netlify.app