fix(angular): allow opening dropdown and signpost with outside click - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.42k stars 761 forks source link

fix(angular): allow opening dropdown and signpost with outside click #6533

Closed steve-haar closed 2 years ago

steve-haar commented 2 years ago

fixes #6462

Signed-off-by: Steve Haar info@stevehaar.com

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Opening a dropdown from an outside click event would not work unless the dropdown had first been opened by the dropdown trigger.
Opening a signpost from an outside click event would not work at all.

This was because the outside click event would bubble up to the document and the popover would immediately close due to the document click listener.

Issue Number: https://github.com/vmware/clarity/issues/6462

What is the new behavior?

You are now able to open both a dropdown and a signpost with an outside click event.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

netlify[bot] commented 2 years ago

✔️ Deploy Preview for zzz-angular-clarity-design-old ready!

🔨 Explore the source changes: 4a45a586a04bd6df331c3b78e9136fc2049565ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61c39c385d991d0007a8fc69

😎 Browse the preview: https://deploy-preview-6533--zzz-angular-clarity-design-old.netlify.app