vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.42k stars 761 forks source link

fix(angular): use spinner the same size as icon for loading icon buttons #6536

Closed steve-haar closed 2 years ago

steve-haar commented 2 years ago

fixes #5967

The default icon size was 16px and the spinner was 18px causing an ellipsis to show

Signed-off-by: Steve Haar info@stevehaar.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The default icon size was 16px and the spinner was 18px causing an ellipsis to show and the spinner to be off center in an icon button when in the loading state.

Issue Number: https://github.com/vmware/clarity/issues/5967

What is the new behavior?

The spinner used in a loading icon button will now be the same size as the icon. This does not change the behavior of small icon buttons having a 13px spinner.

Does this PR introduce a breaking change?

Other information

Instead of setting the spinner to 100% width, we could hard-code it to be the same width as the default icon size (16px).

netlify[bot] commented 2 years ago

✔️ Deploy Preview for zzz-angular-clarity-design-old ready!

🔨 Explore the source changes: e5f7f00d6bab6aecd3adc70d388769fc3e7f9b35

🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61c4ca646386f80007ada6c3

😎 Browse the preview: https://deploy-preview-6536--zzz-angular-clarity-design-old.netlify.app