vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 763 forks source link

fix(angular): Combobox clrMulti input handle string value of 'false' #6547

Closed IrisTien closed 2 years ago

IrisTien commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: #6432

What is the new behavior?

Combobox Component clrMulti input handles both string and boolean type values. If clrMulti input is boolean, it will pass the boolean value directly; If clrMulti input is string: it would treat "false" and empty string to boolean false, it would set to true for all the other strings.

Does this PR introduce a breaking change?

Other information

Jinnie commented 2 years ago

Hello, @IrisTien,

There is a small formatting error that needs to be fixed. And also we need those 4 commits squashed, and then we can merge this fix in.

You can easily accomplish both tasks by soft resetting to the latest "good" commit, then running format:fix on the staged commits and force pushing all back. These are the commands you need:

git reset --soft 5911f81caae3e02ac9b9008c0d82bf07ad040529
npm run format:fix

Then commit (don't forget the "signed-off-by" line) and force push back to your fork. This PR will be automatically updated and build tasks rerun.

Thanks!

ashleyryan commented 2 years ago

Hello, this repository has been archived. Please visit one of the new repositories: