vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 763 forks source link

fix(react): change react version to be >= 16.13.1 - backport v5 #6550

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

Fix #6464

Signed-off-by: Ashley Ryan asryan@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What is the current behavior?

Issue #6464

@cds/react has react 16 as a dependency which can cause two version of react if apps are using v17.

What is the new behavior?

react is now a peer dependency

Does this PR introduce a breaking change?

I think moving a dependency to a peerDependency is technically a breaking change, but there's no way an app would use @cds/react without already having react/react-dom.

Other information

There's probably a lot more to test with this, I was hoping this could be a jumping off point for discussion