Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
@cds/react has react 16 as a dependency which can cause two version of react if apps are using v17.
What is the new behavior?
react is now a peer dependency
Does this PR introduce a breaking change?
[x] Yes
[ ] No
I think moving a dependency to a peerDependency is technically a breaking change, but there's no way an app would use @cds/react without already having react/react-dom.
Other information
There's probably a lot more to test with this, I was hoping this could be a jumping off point for discussion
Fix #6464
Signed-off-by: Ashley Ryan asryan@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
Issue #6464
@cds/react has react 16 as a dependency which can cause two version of react if apps are using v17.
What is the new behavior?
react is now a peer dependency
Does this PR introduce a breaking change?
I think moving a dependency to a peerDependency is technically a breaking change, but there's no way an app would use @cds/react without already having react/react-dom.
Other information
There's probably a lot more to test with this, I was hoping this could be a jumping off point for discussion