vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 763 forks source link

fix(dropdown): set min height and width for angle icon #6557

Closed gerinjacob closed 2 years ago

gerinjacob commented 2 years ago

Signed-off-by: gerinjacob gerinjacob@gmail.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Size of angle icon inside dropdown is bigger, since it ignores the height and width values set in dropdown style. min-height and min-width set as part of https://github.com/vmware/clarity/commit/629537a5554aa21f7cc0406c2aae02954a576f83 is causing this issue.

Issue Number: N/A

What is the new behavior?

In addition to height and width also set min height and width in dropdown style.

Does this PR introduce a breaking change?

Other information

bbogdanov commented 2 years ago

Hi @gerinjacob,

Thank you for the contribution. I would like to take some time to check if this is the optimal solution.

The base should be angular for the branch. We will take care of the backporting to the v12 and v5.

gerinjacob commented 2 years ago

@bbogdanov , created PR - https://github.com/vmware/clarity/pull/6558 for angular branch. Closing this one.