fix(dropdown): set min height and width for angle icon - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

fix(dropdown): set min height and width for angle icon #6558

Closed gerinjacob closed 2 years ago

gerinjacob commented 2 years ago

@cds/core is now setting min height and width for all icons. So height and width override in dropdown was having no effect. Added min height and width.

Signed-off-by: gerinjacob gerinjacob@gmail.com

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Size of angle icon inside dropdown is bigger, since it ignores the height and width values set in dropdown style. min-height and min-width set as part of 629537a is causing this issue.

Issue Number: N/A

What is the new behavior?

In addition to height and width also set min height and width in dropdown style.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

netlify[bot] commented 2 years ago

✔️ Deploy Preview for zzz-angular-clarity-design-old ready!

🔨 Explore the source changes: 46f5c8dd6564b3bb34cad4395deed53fbb3f599a

🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61d6e191a362a1000819e7f1

😎 Browse the preview: https://deploy-preview-6558--zzz-angular-clarity-design-old.netlify.app

gerinjacob commented 2 years ago

Here is the stackblitz, that replicates the issue, @cds/core=5.6.0 (working) - https://stackblitz.com/edit/clarity-light-theme-v5-cu1rga @cds/core=5.6.1 (issue) - https://stackblitz.com/edit/clarity-light-theme-v5-fijvox

steve-haar commented 2 years ago

Closing. This has been fixed with https://github.com/vmware/clarity/commit/0cb5c3b6d1c41cb1fd57f84088db47481d15d698