React(CdsButton): loadingStatus prop not working - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

React(CdsButton): loadingStatus prop not working #6559

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

Describe the bug

The loadingState prop of CdsButton no longer does anything. loading-state must be used instead.

How to reproduce

loadingState doesn't work: https://stackblitz.com/edit/clairty-core-react-dark-v5-zacfgr?file=src%2FApp.tsx loading-state works: https://stackblitz.com/edit/clairty-core-react-dark-v5-56yx2w?file=src%2FApp.tsx

Expected behavior

It's expected that the property setting for loading-state/loadingState should work when using the prop loadingState. It broke in 5.5.1

Versions

Clarity project:

[x] Clarity Core
[ ] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[ x] v5.x

Framework:

[ ] Angular
[x] React
[ ] Vue
[ ] Other:

Additional notes

Here's an example with the prop working in 5.5.0: https://stackblitz.com/edit/http-server-ugdktg?file=src%2FApp.tsx

The issue may be related to this PR: https://github.com/vmware/clarity/pull/6183/files

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.