clr alert fixes - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

clr alert fixes #6560

Closed steve-haar closed 2 years ago

steve-haar commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

This PR fixes three related bugs involving alerts opening and closing (see the three commits for details)

Issue Number: https://github.com/vmware/clarity/issues/5468

What is the new behavior?

This PR fixes three related bugs involving alerts opening and closing (see the three commits for details)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

netlify[bot] commented 2 years ago

✔️ Deploy Preview for zzz-angular-clarity-design-old ready!

🔨 Explore the source changes: 6ef46e8a89e2c3f9d221ced6ed37bd0730269c41

🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61d8a3c4a9f26000073f65e1

😎 Browse the preview: https://deploy-preview-6560--zzz-angular-clarity-design-old.netlify.app