feat(angular): do not preserve width of loading buttons

steve-haar commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently, loading buttons preserve their width when they switched to the loading state.

fixes https://github.com/vmware/clarity/issues/5967

What is the new behavior?

Loading buttons will no longer preserve their width. This also fixes styling issues when a button was initialized in the loading state.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other Information

The previous fix for same size icons is no longer needed if the button is not going to preserve its width.

vmwclabot commented 2 years ago

@steve-haar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.