search

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 763 forks source link

fix(angular): vertical align icon in dropdown button #6565

Closed steve-haar closed 2 years ago

steve-haar commented 2 years ago

Signed-off-by: Steve Haar info@stevehaar.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

cds-icon inside of a clrDropdownTrigger was not vertically centered.

fixes https://github.com/vmware/clarity/issues/6448

What is the new behavior?

The cds-icon will now be vertically centered

Does this PR introduce a breaking change?

netlify[bot] commented 2 years ago

✔️ Deploy Preview for zzz-angular-clarity-design-old ready!

🔨 Explore the source changes: fe00d671de113d3135372e7b4b1e01c68e4e0e5a

🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61dca7c207c00f0008713631

😎 Browse the preview: https://deploy-preview-6565--zzz-angular-clarity-design-old.netlify.app

steve-haar commented 2 years ago

We fixed this yesterday with 0cb5c3b

@mathisscott, the fix in https://github.com/vmware/clarity/commit/0cb5c3b6d1c41cb1fd57f84088db47481d15d698 is a specific change to the angle icon in the dropdown trigger, this is something different. This addresses an alignment issue that affects any non angle icons placed inside of a dropdown trigger.

mathisscott commented 2 years ago

@mathisscott, the fix in 0cb5c3b is a specific change to the angle icon in the dropdown trigger, this is something different. This addresses an alignment issue that affects any non angle icons placed inside of a dropdown trigger.

My bad. I thought this was addressing the same issue as that commit.