topic/loading button min width

steve-haar commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Initializing a button to loading will cause it to have the width of the button as if it only contained the loading spinner. Subsequently (or just not initially) setting the button to loading, the button will have the width of the button in its default state.

Issue Number: https://github.com/vmware/clarity/issues/5967

What is the new behavior?

Loading buttons will always have a minimum width so that the spinner will fully show.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

vmwclabot commented 2 years ago

@steve-haar, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.