fix(react:button): move loadingStatus logic to `update` event - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

fix(react:button): move loadingStatus logic to `update` event #6576

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In React, the loadingStatus prop no longer works, devs must use loading-status. It last worked in 5.5.0/

Issue Number: #6559

What is the new behavior?

loadingStatus works in React now

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information