Closed bbogdanov closed 2 years ago
✔️ Deploy Preview for zzz-angular-clarity-design-old ready!
🔨 Explore the source changes: e5d6d6718a5164556fc754376c15db07eeb6c9f7
🔍 Inspect the deploy log: https://app.netlify.com/sites/zzz-angular-clarity-design-old/deploys/61f019ff9948470007046ad5
😎 Browse the preview: https://deploy-preview-6587--zzz-angular-clarity-design-old.netlify.app
Closes #6465
Signed-off-by: Bogdan Bogdanov bbogdanov@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
6465
What is the new behavior?
The position operators of the popup manages to keep the popup in the viewport and not cut the content
Does this PR introduce a breaking change?
Other info
https://github.com/vmware/clarity/blob/c3736a37bea7e12a43d2ed097870beb5be62c9e8/projects/angular/src/utils/popover/providers/popover-position.service.ts#L92 This should be able to actually fix the issue but the problem is that we cannot get to this if because of https://github.com/vmware/clarity/blob/c3736a37bea7e12a43d2ed097870beb5be62c9e8/projects/angular/src/data/datagrid/datagrid-filter.ts#L107
Even that I introduced a new
else if
that checkes theClrAxis.Vertical
and0 > horizontalOffset
it doesn't solve the problem. It would require some changes in here as well https://github.com/vmware/clarity/blob/c3736a37bea7e12a43d2ed097870beb5be62c9e8/projects/angular/src/utils/popover/providers/popover-position.service.ts#L188 And that will lead to eventually make changes https://github.com/vmware/clarity/blob/c3736a37bea7e12a43d2ed097870beb5be62c9e8/projects/angular/src/utils/popover/position-operators.ts#L88 which is what I did.