chore(core): support mac monterey - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

chore(core): support mac monterey #6592

Closed coryrylan closed 2 years ago

coryrylan commented 2 years ago

bump playwright dep to support the latest mac monterey version

Signed-off-by: Cory Rylan splintercode.cb@gmail.com

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The core unit tests may fail on the latest Mac OS Monterey version from not being able to access the chromium path instance.

What is the new behavior?

This bumps the playwright version to add support and enable the tests to pass as normal.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

hippee-lee commented 2 years ago

I was running into this earlier when helping with the website stuff. Thank you for fixing this!!