vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 763 forks source link

build: remove curl script and add github secret for NETLIFY_AUTH_TOKEN #6600

Closed hippee-lee closed 2 years ago

hippee-lee commented 2 years ago

Signed-off-by: Matt Hippely mhippely@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce? Removes the curl script that was downloading the NETLIFY_AUTH_TOKEN from the firebase cloud function. It implements a github secret that sets up the environment more securely.

What is the current behavior?

Currently build jobs download the NETLIFY_AUTH_TOKEN for commits and PR's from a firebase cloud function for a small set if github container IP's. While this works and is more secure than commiting the AUTH token to code, its not great either.

Issue Number: N/A

What is the new behavior?

This change adds and configures usage of a github secret to initialize the build environment with a github secret for the NETLIFY_AUTH_TOKEN.

Does this PR introduce a breaking change?

Other information