vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

fix(core:icon): update icon warning color to use the dark color variation #6608

Closed hippee-lee closed 2 years ago

hippee-lee commented 2 years ago

This came up during a review of the documentation. Icon warning colors for icons and badges were not correct.

Before

Screen Shot 2022-01-28 at 1 55 42 PM

After

Screen Shot 2022-01-28 at 1 54 19 PM

Signed-off-by: Matt Hippely mhippely@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The warning color was not correct for icons and icon badges.

Issue Number: N/A

What is the new behavior?

The warning color has been updated to use the --cds-alias-status-warning-dark color token.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

This may impact applications doing visual regression testing depending on the tolerance values they have configured for the tooling.

Other information