Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
Please check if your PR fulfills the following requirements:
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval
PR Type
What kind of change does this PR introduce?
This is a redo of a fix introduced in the v13.0.0 release. The issue is related to the positioning and sizing of the dropdown toggle button's angle/caret icon.
The original fix worked alright for v13 when used with 5.6.2 and later but did not work for 5.6.0.
Restoring the code that made the dropdown toggle work with 5.6.0- broke the toggle icon positioning in 5.6.2. The fix was updating a css custom property that applied to 5.6.2+ and made it work as expected with 5.6.0-.
I tested these changes in v12 and v13 with Core 5.6.0, 5.6.2, and 6.0.0-next.3. The differences between 5.6.0 and 5.6.2+ were the complicating factor.
This will be backported to v12.
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
Signed-off-by: Scott Mathis smathis@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
This is a redo of a fix introduced in the v13.0.0 release. The issue is related to the positioning and sizing of the dropdown toggle button's angle/caret icon.
The original fix worked alright for v13 when used with 5.6.2 and later but did not work for 5.6.0.
Restoring the code that made the dropdown toggle work with 5.6.0- broke the toggle icon positioning in 5.6.2. The fix was updating a css custom property that applied to 5.6.2+ and made it work as expected with 5.6.0-.
I tested these changes in v12 and v13 with Core 5.6.0, 5.6.2, and 6.0.0-next.3. The differences between 5.6.0 and 5.6.2+ were the complicating factor.
This will be backported to v12.
Does this PR introduce a breaking change?