search

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

Updated the close icon's name #6631

Closed spollard closed 2 years ago

spollard commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The close icon on the angular App Layout example code does not load, because it uses the wrong shape name. It uses shape='close', but the correct shape name is 'window-close'.

Issue Number: N/A

What is the new behavior?

The close icon on the angular App Layout example code DOES load.

Does this PR introduce a breaking change?

Other information

vmwclabot commented 2 years ago

@spollard, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 2 years ago

@spollard, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

spollard commented 2 years ago

I created a new pull request because some previous commits were not signed off. When I went back to amend those changes, it got messy, so I just started a new PR. I don't see that I have permissions to delete or close this PR, so can somebody else please do that?