[Backport] fix(react): fix jsdom react testing issues - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 763 forks source link

[Backport] fix(react): fix jsdom react testing issues #6636

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

Fixes #5985

Add isNode check to property syncing in cdscontrol to prevent error

Fixes #6525:

Remove isNode check for aria-reflect, now that all roles are set in connectedCallback (#6593)

Signed-off-by: Ashley Ryan asryan@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue #5985 When rendering CdsSelect in jsdom (via react-testing-library), an exception will be thrown on render and all tests will fail.

Issue #6525 The aria-reflect polyfill doesn't run in node because of jsdom exceptions, meaning react unit tests can't target elements by role

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information