vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 763 forks source link

fix(angular:vertical-nav): navgroup togglebtn a11y #6644

Closed mathisscott closed 2 years ago

mathisscott commented 2 years ago

• this adds a new input to the clr-vertical-nav-group component • the new input is groupLabel/clrVerticalNavGroupLabel • it defaults to commonstrings.keys.verticalNavGroupToggle • if supplied a value, it updates the aria-label on the toggle button • previously, a custom label could not be provided to the toggle button • ...without non-trivial overrides to commonstrings

Signed-off-by: Scott Mathis smathis@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

See commit notes.

Issue Number: Tracked in a11y Jira

What is the new behavior?

See commit notes.

Does this PR introduce a breaking change?

Other information

mathisscott commented 2 years ago

This fix can be backported to v12. If we want to backport it to unsupported versions, it should backport to v5 and/or v4 as well.