`shape` property for <cds-icon> is missing in @cds/angular@6.0.0-next.4 - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

`shape` property for <cds-icon> is missing in @cds/angular@6.0.0-next.4 #6656

Closed thojo closed 2 years ago

thojo commented 2 years ago

Describe the bug

In version 6.0.0-next.4 the shape property in the d.ts file of <cds-icon> is gone which leads to build failures.

How to reproduce

Steps to reproduce the behavior:

Go to https://unpkg.com/browse/@cds/angular@6.0.0-next.3/icon/cds-icon.directive.d.ts
Compare with https://unpkg.com/browse/@cds/angular@6.0.0-next.4/icon/cds-icon.directive.d.ts
See missing shape getter and setter

Expected behavior

The shape attribute for CdsIcon should be usable from Angular (again):

<cds-icon shape="user">

Versions

Clarity project:

[x] Clarity Core
[ ] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[ ] v5.x
[x] v6.x

Framework:

[x] Angular
[ ] React
[ ] Vue
[ ] Other:

Framework version: Angular 12 and 13

Additional notes

A workaround is to use attribute binding syntax:

<cds-icon [attr.shape]="'user'">

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.