fix(alert): replace title with aria-label on alert icon - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

fix(alert): replace title with aria-label on alert icon #6663

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

Signed-off-by: Ashley Ryan asryan@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The icon used a title attribute to denote the status of the alert, which is not accessible to keyboard users.

What is the new behavior?

The icon has role="img" and uses aria-label to match Core Alerts behavior: https://clarity.design/storybook/core/?path=/story/components-alert--page

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information