search

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

[clr-datagrid] Details pane throws change detection error #6673

Closed alexey-shakura closed 2 years ago

alexey-shakura commented 2 years ago

Describe the bug

I see change detection errors when interacting with pagination/changing the list of data while details pane is open. Screen Shot 2022-02-10 at 12 37 12 PM

How to reproduce

https://stackblitz.com/edit/clarity-dark-theme-clr12-cds5-j7vobj?file=src/app/app.component.ts

Steps to reproduce the behavior:

  1. Open details pane on the first page
  2. Click next page
  3. Check out the console: "ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'attr.aria-label': 'Close'. Current value: 'Open'.. "

Expected behavior

Nothing special here, simple local data passed to datagrid, I expect no errors in console

Versions

Clarity project:

Clarity version:

Framework:

Framework version: Angular 12

Device:

Additional notes

alexey-shakura commented 2 years ago

@coryrylan any updates on this ?

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.