vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

fix(tree-view): remove duplicate aria roll from treenode #6675

Closed mathisscott closed 2 years ago

mathisscott commented 2 years ago

Signed-off-by: Scott Mathis smathis@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: ..from a11y list

What is the new behavior?

The aria role now only exists on the tree-node's focusable content container. Previously, both the content container of the tree item and its parent angular component had the same role. This was a problem for the a11y team's automated tests.

Does this PR introduce a breaking change?

Other information

mathisscott commented 2 years ago

This is a fix that can be backported.