vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

fix(accordion): remove role=modal #6681

Closed hippee-lee closed 2 years ago

hippee-lee commented 2 years ago

This PR is a back port of the issue fixed on next.

The VMware accessibility team identified the role=modal attribute on panel divs as a violation for VMware specific accessibility criteria. This change removes the role=group attribute from clr-accordion-panel divs template element.

Signed-off-by: Matt Hippely mhippely@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Accordion panels have the attribute role="model" on one of the container divs.

Issue Number: N/A

What is the new behavior?

This change removes the role attribute from the accordion panel div container.

Does this PR introduce a breaking change?

Other information