fix(navigation): better aria labels for responsive nav - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

fix(navigation): better aria labels for responsive nav #6683

Closed mathisscott closed 2 years ago

mathisscott commented 2 years ago

Signed-off-by: Scott Mathis smathis@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: VPAT-4746

What is the new behavior?

Common Strings for responsive nav toggles have been updated

Does this PR introduce a breaking change?

[x] Yes* - technically yes. but minor and definitely an edge case for most products.
[ ] No

Other information

mathisscott commented 2 years ago

This is not a candidate for backporting.