search

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

cannot work updateFilterValue with custom filters #6702

Closed kitodev closed 2 years ago

kitodev commented 2 years ago

Describe the bug

I want to use updateFilterValue when click to clear all filter button, but it does not work with the built in filters:

https://stackblitz.com/edit/clear-allfilter?file=src/app/app.component.ts

Versions

Clarity project:

Clarity version:

Framework:

Framework version: Angular 13

Jinnie commented 2 years ago

It does work with built-in filters. Here's your StackBlitz from the previous bug, updated: https://stackblitz.com/edit/clear-allfilter-ur3tzc?file=src%2Fapp%2Fapp.component.ts

The difference with the new StackBlitz is that it features some custom filters, which are themselves not working in the linked demo above, see your HTML template. Probably left-over from some attempts to make it work with custom filters?

kitodev commented 2 years ago

@Jinnie thank you for the response. in fact, i want to use the Clear Filter option on the custom filter. There is any solutions maybe, how can i do that?

Jinnie commented 2 years ago

@kitodev I'd ask to start with a working reproduction. The above StackBlitz does not really work, so I can't say or debug now at what level the functionality gets broken. I'll reopen the issue and mark it as needing reproduction.

github-actions[bot] commented 1 year ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.