vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

a11y(angular:datagrid): vpat-763 #6705

Closed hippee-lee closed 2 years ago

hippee-lee commented 2 years ago

This change implements fixes for issues reported in vpat-763 report

  1. Adds sibling span with button text and .clr-sr-only class
  2. Adds aria-expanded attribute to the toggle button in datagrid footer

Signed-off-by: Matt Hippely mhippely@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Screen readers do not read out button text for the hid/show feature button controls. There is a missing aria-expanded attribute on the main toggle button in the datagrid footer.

Issue Number: N/A

What is the new behavior?

Screen readers read out the button text and for the main toggle button in datagrid footer they read out the aria-expanded attribute.

Does this PR introduce a breaking change?

Other information

hippee-lee commented 2 years ago

@Jinnie - I updated the title. When reviewing the code changes there was a patch that didn't get applied for the pagination buttons which are also part of this vpat issue.