vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.
http://clarity.design
MIT License
6.43k stars 762 forks source link

fix(tree-view): execute expand on enter and enter #6714

Closed mathisscott closed 2 years ago

mathisscott commented 2 years ago

• there was a bug where spacebar was coming through as a blank space • we weren't catching that, now we are • made it so the enter and space keys also try to open/close if... they are used on a parent tree node

Signed-off-by: Scott Mathis smathis@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: vpat 684

What is the new behavior?

Does this PR introduce a breaking change?

Other information

mathisscott commented 2 years ago

This change can be backported if it needs to be

mathisscott commented 2 years ago

This change can be backported if it needs to be

I saw those and thanks for drawing my attention to that. I'm working through the use case of selectable tree nodes right now. I will push an update once I have those working (again) as expected.