fix: icon color in disabled buttons - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

fix: icon color in disabled buttons #6716

Closed Shijir closed 2 years ago

Shijir commented 2 years ago

Signed-off-by: stsogoo stsogoo@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

Disabled button icons don't show their proper disabled color. This PR fixes the issue. This fix complements https://github.com/vmware/clarity/pull/6715 for the shim.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Before:

Screen Shot 2022-02-18 at 3 10 56 PM

After:

Screen Shot 2022-02-18 at 3 10 19 PM