fix(date-picker): better denote selected date - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

fix(date-picker): better denote selected date #6739

Closed ashleyryan closed 2 years ago

ashleyryan commented 2 years ago

include selected date in button label
add aria-selected to date in calendar

fixes VPAT-662

Signed-off-by: Ashley Ryan asryan@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The selected date in the calendar in the modal does not have aria-selected on it after a date has been selected

What is the new behavior?

Added aria-selected to the button, also changed the label on the button to switch between "Choose date" and "Change date, {date}" when selected.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information