Publish as Ivy Distribution

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

Publish as Ivy Distribution #6745

Closed TekSiDoT closed 2 years ago

TekSiDoT commented 2 years ago

Describe the bug

@cds/angular latest (5.6.4 as of writing) is still being distributed as legacy View Engine library.

How to reproduce

Any fresh repo w/o prior ngcc run.

Expected behavior

Clarity should be distributed as an Ivy Distribution

Versions

Clarity project:

[x] Clarity Core
[ ] Clarity Angular/UI

Clarity version:

[ ] v3.x
[ ] v4.x
[x] v5.x

Framework:

[x] Angular
[ ] React
[ ] Vue
[ ] Other:

Framework version: Angular 13

coryrylan commented 2 years ago

Yes it looks like this was disabled due to a compatibility issue we were waiting on for angular v12 here https://github.com/vmware/clarity/pull/5888/files

We should be able to migrate cds/angular to use compilationMode: 'partial' to at least match clr/angular. This should be applied to v6 and v5 cds/angular. https://github.com/vmware/clarity/blob/angular/projects/angular/tsconfig.lib.prod.json#L8

It might also be worth investigation on when libraries should move from partial to full as its currently not clear https://angular.io/guide/angular-compiler-options#compilationmode

coryrylan commented 2 years ago

Will go out with next release for v6 and v5

github-actions[bot] commented 2 years ago

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.